SRE-2330 cleanup references to auth-email #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 74.19% 74.19% -0.01%
==========================================
Files 253 253
Lines 21897 21893 -4
==========================================
- Hits 16247 16244 -3
+ Misses 5650 5649 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sneakernuts
force-pushed
the
SRE-2330-deprecate-usage-of-auth-email-in-sdk-internal
branch
from
d46814e to
2d4356c
Compare
Hinton
reviewed
Aug 15, 2025
Hinton
previously approved these changes
Aug 18, 2025
Co-authored-by: Oscar Hinton <[email protected]>
|
Hinton
approved these changes
Aug 18, 2025
dani-garcia
approved these changes
Aug 18, 2025
sneakernuts
deleted the
SRE-2330-deprecate-usage-of-auth-email-in-sdk-internal
branch
This was referenced Aug 18, 2025
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SRE-2330
📔 Objective
Part of overall effort to deprecate auth-email header
Server side changes: bitwarden/server#5709
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes